Add timestamp annotation on update #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
restart-on-update
branch
from
7726709
to
10a144d
Compare
pkosiec
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
With an upgrade which nothing changes works flawlessly 👍 But I noticed sometimes we don't show the logs when we do actual upgrade (which recreates the pod during actual upgrade). See the video for details - looks like a race condition issue.
Screen.Recording.2023-07-17.at.09.42.15.mp4
I don't think this is something very urgent, but maybe easy to fix? if not, we can do it in a follow-up.
mszostok
added a commit
that referenced
this pull request
Jul 17, 2023
* Fix brew release, add windows, use binary format (#1144) * Add build flags to CLI (#1146) * Plugins logger respect generic logger settings (#1147) * Add timestamp annotation on update (#1148) * Rename `--auto-upgrade` to `--auto-approve` flag for Migration CLI (#1149) * Unify auto-approve flag for Migration CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request: